Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReturn the old draw buffer when resizing. #132
Merged
Conversation
|
r? @emilio |
| pub fn resize(&mut self, size: Size2D<i32>) -> Result<DrawBuffer, &'static str> { | ||
| if let Some(draw_buffer) = self.draw_buffer.take() { | ||
| let color_attachment_type = draw_buffer.color_attachment_type(); | ||
| self.init_offscreen(size, color_attachment_type).map(|()| draw_buffer) |
This comment has been minimized.
This comment has been minimized.
emilio
Jan 15, 2019
Member
Probably slightly nicer like:
self.init_offscreen(..)?;
Ok(draw_buffer)But no big deal.
|
@bors-servo r=emilio |
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Jan 17, 2019
Update webrender Depends on servo/surfman#132. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22598) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Jan 18, 2019
Update webrender Depends on servo/surfman#132. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22598) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedJan 14, 2019
No description provided.