Skip to content

/ surfman

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cargo feature to force EGL on windows #136

Merged
merged 5 commits into from Jun 10, 2019
Merged

Add a cargo feature to force EGL on windows #136

merged 5 commits into from Jun 10, 2019

Conversation

@jdm
Copy link
Member

jdm commented May 30, 2019 •
edited

Depends on servo/mozangle#21.

This change is Reviewable
@jdm
Copy link
Member Author

jdm commented May 30, 2019

This is untested so far.
@jdm jdm force-pushed the jdm:win-egl branch from ad2611f to 4c9e1ac May 30, 2019
@jdm
Update to rust 2018.
31aa30b
@jdm jdm force-pushed the jdm:win-egl branch from 4c9e1ac to f795975 May 30, 2019
@jdm jdm mentioned this pull request May 30, 2019
Closed
jdm added 2 commits May 30, 2019
@jdm
Enable EGL in Windows.
357a8aa
@jdm
Add appveyor config
Loading status checks…
b1f99d2
@jdm jdm force-pushed the jdm:win-egl branch from f795975 to b1f99d2 May 30, 2019
@paulrouget
Copy link
Contributor

paulrouget commented Jun 3, 2019

This appears to work. As in, no link to opengl32. Thanks.
@jdm jdm force-pushed the jdm:win-egl branch from 358ca93 to b1f99d2 Jun 7, 2019
@jdm jdm mentioned this pull request Jun 7, 2019
Merged
5 of 6 tasks complete
bors-servo added a commit to servo/servo that referenced this pull request Jun 7, 2019
@bors-servo
Auto merge of #23468 - servo:jdm-patch-52, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c072884 
Add Windows arm64 build.

Depends on:
* [ ] servo/mozjs#184
* [ ] servo/ipc-channel#232
* [ ] alexcrichton/cmake-rs#82
* [ ] servo/surfman#136
* [ ] servo/mozangle#21

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468)
<!-- Reviewable:end -->
bors-servo added a commit to servo/servo that referenced this pull request Jun 7, 2019
@bors-servo
Auto merge of #23468 - servo:jdm-patch-52, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
17f039b 
Add Windows arm64 build.

Depends on:
* [ ] servo/mozjs#184
* [ ] servo/ipc-channel#232
* [ ] alexcrichton/cmake-rs#82
* [ ] servo/surfman#136
* [ ] servo/mozangle#21

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468)
<!-- Reviewable:end -->
bors-servo added a commit to servo/servo that referenced this pull request Jun 7, 2019
@bors-servo
Auto merge of #23468 - servo:jdm-patch-52, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
23d995a 
Add Windows arm64 build.

Depends on:
* [ ] servo/mozjs#184
* [ ] <strike>https://github.com/servo/ipc-channel/pull/232</strike>
* [x] alexcrichton/cmake-rs#82
* [ ] servo/surfman#136
* [ ] servo/mozangle#21

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468)
<!-- Reviewable:end -->
@jdm jdm force-pushed the jdm:win-egl branch from 71010fe to cbe15c0 Jun 7, 2019
bors-servo added a commit to servo/servo that referenced this pull request Jun 7, 2019
@bors-servo
Auto merge of #23468 - servo:jdm-patch-52, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ed4f45f 
Add Windows arm64 build.

Depends on:
* [x] servo/mozjs#184
* [ ] <strike>https://github.com/servo/ipc-channel/pull/232</strike>
* [x] alexcrichton/cmake-rs#82
* [ ] servo/surfman#136
* [ ] servo/mozangle#21

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468)
<!-- Reviewable:end -->
@jdm
Copy link
Member Author

jdm commented Jun 10, 2019

r? @Manishearth (this goes along with the changes in servo/mozangle#21)
@Manishearth
Manishearth approved these changes Jun 10, 2019
View changes
jdm added 2 commits Jun 7, 2019
@jdm
Ensure static EGL builds are successful on Windows.
4132cea
@jdm
Publish 0.22.2.
Loading status checks…
20f6bba
@jdm jdm force-pushed the jdm:win-egl branch from cbe15c0 to 20f6bba Jun 10, 2019
@jdm
Copy link
Member Author

jdm commented Jun 10, 2019

@bors-servo r=Manishearth
@jdm jdm merged commit 443b706 into servo:master Jun 10, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
bors-servo added a commit to servo/servo that referenced this pull request Jun 11, 2019
@bors-servo
Auto merge of #23468 - servo:jdm-patch-52, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
82aade1 
Add Windows arm64 build.

Depends on:
* [x] servo/mozjs#184
* [ ] <strike>https://github.com/servo/ipc-channel/pull/232</strike>
* [x] alexcrichton/cmake-rs#82
* [x] servo/surfman#136
* [x] servo/mozangle#21

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468)
<!-- Reviewable:end -->
bors-servo added a commit to servo/servo that referenced this pull request Jun 11, 2019
@bors-servo
Auto merge of #23468 - servo:jdm-patch-52, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
568f8d0 
Add Windows arm64 build.

Depends on:
* [x] servo/mozjs#184
* [ ] <strike>https://github.com/servo/ipc-channel/pull/232</strike>
* [x] alexcrichton/cmake-rs#82
* [x] servo/surfman#136
* [x] servo/mozangle#21

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468)
<!-- Reviewable:end -->
bors-servo added a commit to servo/servo that referenced this pull request Jun 11, 2019
@bors-servo
Auto merge of #23468 - servo:jdm-patch-52, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3085677 
Add Windows arm64 build.

Depends on:
* [x] servo/mozjs#184
* [x] servo/rust-mozjs#463
* [ ] <strike>https://github.com/servo/ipc-channel/pull/232</strike>
* [x] alexcrichton/cmake-rs#82
* [x] servo/surfman#136
* [x] servo/mozangle#21

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468)
<!-- Reviewable:end -->
bors-servo added a commit to servo/servo that referenced this pull request Jun 11, 2019
@bors-servo
Auto merge of #23468 - servo:jdm-patch-52, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8e78357 
Add Windows arm64 build.

Depends on:
* [x] servo/mozjs#184
* [x] servo/rust-mozjs#463
* [ ] <strike>https://github.com/servo/ipc-channel/pull/232</strike>
* [x] alexcrichton/cmake-rs#82
* [x] servo/surfman#136
* [x] servo/mozangle#21

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@jdm @paulrouget @Manishearth
You can’t perform that action at this time.