Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd IOSurface ColorAttachment kind #137
Conversation
| self.gl().tex_parameter_i(gl::TEXTURE_RECTANGLE, gl::TEXTURE_WRAP_S, gl::CLAMP_TO_EDGE as GLint); | ||
| self.gl().tex_parameter_i(gl::TEXTURE_RECTANGLE, gl::TEXTURE_WRAP_T, gl::CLAMP_TO_EDGE as GLint); | ||
|
|
||
| self.gl().bind_texture(gl::TEXTURE_2D, 0); |
This comment has been minimized.
This comment has been minimized.
|
This looks ok, but we need to figure out the issue with reset_draw_buffer. |
|
@jdm I made the proposed changes, also changed the swap logic according to servo/servo#23509 (comment). I still need to look into the |
|
Adding the |
|
We'll need to increase the Cargo version to 0.23 as well. |
|
This PR now depends on servo/core-foundation-rs#324 |
zakorgy
force-pushed the
zakorgy:io-surface
branch
2 times, most recently
from
7953725
to
4d36730
|
@jdm I have updated the PR and increased the crate version. Shall I squash the changes in one commit? |
|
Yes, go ahead. |
|
Squashed everything except the version bump commit. |
|
@bors-servo r+ |
zakorgy commentedJun 4, 2019
•
edited by larsbergstrom
Use IOSurfaces bound to textures as Framebuffer attachments, based on #131.
We have three textures bound to IOSurfaces, one active (bound to the context), one complete and one published to the WR thread. I found that using three IOSurfaces was the most more appropriate solution.
The body of
reset_draw_buffer_contentsis empty because that caused wrong background colors with servo/servo#23509, I still need to figure out that part.This change is