Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add IOSurface support" #145

Merged
merged 1 commit into from Jul 24, 2019
Merged

Revert "Add IOSurface support" #145

merged 1 commit into from Jul 24, 2019

Conversation

@jdm
Copy link
Member

jdm commented Jul 24, 2019

This reverts commit 92f0e69.

This reverts commit 92f0e69.
@jdm
Copy link
Member Author

jdm commented Jul 24, 2019

@zakorgy Sorry, I need to back these changes out temporarily. We're trying to merge #131 on a short deadline, and the changes required by servo/servo#23509 are making it very challenging. I think we need to add more abstractions that hide the per-platform differences; I made some changes in https://github.com/jdm/rust-offscreen-rendering-context/tree/multiple2 that are based on these changes that introduce a TextureBacking type which I think could make this easier. I will provide more specific pointers for how I think we should modify servo/servo#23509 to make these changes easier to integrate in that PR.

@jdm jdm merged commit 6321b89 into servo:master Jul 24, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@zakorgy
Copy link
Contributor

zakorgy commented Jul 25, 2019

@jdm Thanks for notifying me. Please let me know if #131 and the TextureBacking changes are merged and additional works needs to be done on the IOSurface part. Also looking forward for your pointers for servo/servo#23509 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.