Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix travis yml #154
Merged
Fix travis yml #154
Conversation
| @@ -158,11 +159,11 @@ impl Device { | |||
| ]; | |||
|
|
|||
| EGL_FUNCTIONS.with(|egl| { | |||
| let egl_surface = if let Some(HandleOrTexture::Texture(texture)) = share_handle { | |||
| let egl_surface = if let Some(share_handle) = share_handle { | |||
This comment has been minimized.
This comment has been minimized.
jdm
Mar 25, 2020
Member
These changes don't look like they compile when used with the opexnr webxr backend.
This comment has been minimized.
This comment has been minimized.
jdm
Mar 25, 2020
Member
https://github.com/jdm/surfman/commits/d3d-share is a branch that should address that.
|
If the goal is only to get the build working and the openxr changes will be in a separate PR, that's fine. |
|
This is just to get the build working again, atm everything is red on travis, which is suboptimal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedMar 25, 2020
Gets the travis build to be green again (includes #152 and #153).