Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd check for unconditional recursion, to error if we forget to implement a function #156
+2
−0
Conversation
…ment a function
asajeffrey
force-pushed the
asajeffrey:ban-unconditional-recursion
branch
from
699c1a8
to
d106629
|
@bors-servo r+ |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedMar 25, 2020
At the moment, if a back end forgets to implement one of the trait functions, surfman still builds, but goes into an infinite loop when the function is called. This has bitten me more than once, but is easy to protect against.