Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An API for creating a native widget from a raw pointer #158

Merged
merged 1 commit into from Mar 27, 2020

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Mar 25, 2020

This is needed in servo's C API, which gets the native widget as a void*.

@asajeffrey asajeffrey force-pushed the asajeffrey:native-widget-from-raw-ptr branch from 5085e28 to bc05878 Mar 26, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Mar 26, 2020

The latest upstream changes (presumably #161) made this pull request unmergeable. Please resolve the merge conflicts.

@asajeffrey asajeffrey force-pushed the asajeffrey:native-widget-from-raw-ptr branch from bc05878 to 1e474d4 Mar 26, 2020
@asajeffrey asajeffrey force-pushed the asajeffrey:native-widget-from-raw-ptr branch from 1e474d4 to 811a74e Mar 26, 2020
@jdm
jdm approved these changes Mar 27, 2020
@asajeffrey
Copy link
Member Author

asajeffrey commented Mar 27, 2020

@bors-servo r=jdm

@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2020

📌 Commit 811a74e has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2020

Testing commit 811a74e with merge ebf694e...

@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2020

☀️ Test successful - checks-travis
Approved by: jdm
Pushing ebf694e to master...

@bors-servo bors-servo merged commit ebf694e into servo:master Mar 27, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.