Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gleam and cgl from crates.io #17

Merged
merged 1 commit into from Jun 15, 2015
Merged

Use gleam and cgl from crates.io #17

merged 1 commit into from Jun 15, 2015

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Jun 15, 2015

No description provided.

@emilio
Copy link
Member

emilio commented Jun 15, 2015

@SimonSapin maybe using wildcards could be better, to make less painful updates for servo?

@SimonSapin
Copy link
Member Author

SimonSapin commented Jun 15, 2015

In Cargo, gleam = "0.1" is equivalent to gleam = "^0.1" which is equivalent to gleam = ">=0.1 <0.2". So cargo update will automatically pick up 0.1.1, 0.1.2 etc when we publish them. If we follow SemVer, 0.2 means that there was a breaking change and we might not want to update automatically. I think this is what we want.

https://users.rust-lang.org/t/should-be-used-for-cargo-dependencies/313 has some more discussion.

@emilio
Copy link
Member

emilio commented Jun 15, 2015

Didn't know that, thanks! :)

emilio added a commit that referenced this pull request Jun 15, 2015
Use gleam and cgl from crates.io
@emilio emilio merged commit 5d126b0 into servo:master Jun 15, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@SimonSapin SimonSapin deleted the servo:crates.io-gleam-cgl branch Jun 15, 2015
asajeffrey pushed a commit to asajeffrey/surfman that referenced this pull request Oct 21, 2019
Use OSMesa compat profile when GL version < 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.