Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow failure on glutin platform and minor nits #33
Conversation
|
May you take a quick look at this and tell me if it compiles fine on windows @vvuk? :) (It definitely should, but I have no way to easily test it actually, and our CI is broken because of aster) |
emilio
force-pushed the
windows-tidy
branch
2 times, most recently
from
a682507
to
1519437
|
Seems like CI is broken again due to aster. I could confirm the build and tests passing on linux and mac, and tested the code used in windows and unimplemented platforms. I also changed the feature test, that was working previously just because I was lucky and the vector I was creating contained the memory from old data (I don't even know how I wanted back in the day to get the texture pixels with Android-specific code shouldn't be affected here, so I'm going to merge this. |
|
Good find on the feature test problem :) |
emilio commentedOct 15, 2015
We should probably change
Err(&str)to another type of error...