Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix use of glXChooseFBConfig. #43
Merged
Conversation
Based on https://www.opengl.org/sdk/docs/man2/xhtml/glXChooseFBConfig.xml the last parameter of the attributes array must be None (which == 0). Confusingly, this is different from GLX_NONE, which is non-zero. This fixes webgl context creation on some drivers, in particular nVidia proprietary drivers but probably others too.
|
Wow, good catch. I found this Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedNov 30, 2015
Based on https://www.opengl.org/sdk/docs/man2/xhtml/glXChooseFBConfig.xml
the last parameter of the attributes array must be None (which == 0).
Confusingly, this is different from GLX_NONE, which is non-zero.
This fixes webgl context creation on some drivers, in particular nVidia proprietary drivers but probably others too.