Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upplatform/egl: Fix EGL texture implementation #47
Merged
+42
−17
Conversation
The EGL test failures where provoked by two things: * GLES 2.0 deprecates `gl::TEXTURE_2D` as a valid parameter to `gl::enable`, which was provoking an unexpected INVALID_ENUM error. * GLES 2.0 doesn't have `glGetTexImage`, so to test that writing to a texture actually works we have to bind it to another FBO. We do it on the sharing test. Also, added a no-op feature to easily run egl tests on linux.
|
Merging it directly since it only affects with the removal of one LoC of non-tests. |
emilio
added a commit
that referenced
this pull request
Dec 22, 2015
platform/egl: Fix EGL texture implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedDec 22, 2015
The EGL test failures where provoked by two things:
gl::TEXTURE_2Das a valid parameter togl::enable, which was provoking an unexpected INVALID_ENUM error.glGetTexImage, so to test that writing to atexture actually works we have to bind it to another FBO. We do it on
the sharing test.
Also, added a no-op feature to easily run egl tests on linux. Too bad we can't test it on Travis :(