Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gl_generator to 0.5 #52

Merged
merged 1 commit into from Apr 6, 2016
Merged

Update gl_generator to 0.5 #52

merged 1 commit into from Apr 6, 2016

Conversation

@jdm
Copy link
Member

jdm commented Apr 6, 2016

No description provided.

@emilio emilio force-pushed the jdm-patch-1 branch 2 times, most recently from b5bc5e9 to 350ba75 Apr 6, 2016
@emilio
Copy link
Member

emilio commented Apr 6, 2016

@jdm Travis complained, so I updated your patch with gl_generator's API changes.

If travis passes (it should), I'll merge it and publish it right away.

@emilio emilio changed the title Update gl_generator to 0.5 [do-not-merge] Update gl_generator to 0.5 Apr 6, 2016
@emilio
Copy link
Member

emilio commented Apr 6, 2016

Don't merge this, it panics when calling a glx functions due to they being not loaded, I'm checking if this is expected in brendanzab/gl-rs#403.

@emilio emilio force-pushed the jdm-patch-1 branch from 350ba75 to d3355c5 Apr 6, 2016
@emilio emilio changed the title [do-not-merge] Update gl_generator to 0.5 Update gl_generator to 0.5 Apr 6, 2016
@emilio
Copy link
Member

emilio commented Apr 6, 2016

This is ready to merge, I used GlobalGenerator instead of StaticGenerator, and everything keeps working just fine now :)

@emilio emilio merged commit 3ccecb5 into master Apr 6, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@emilio emilio deleted the jdm-patch-1 branch Apr 6, 2016
asajeffrey pushed a commit to asajeffrey/surfman that referenced this pull request Jan 23, 2020
Support Clone for mutli::Connection and Adapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.