Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd max texture size members to GLLimits #55
Merged
Conversation
src/gl_limits.rs
Outdated
| @@ -4,12 +4,16 @@ use gleam::gl; | |||
| #[cfg_attr(feature="serde_serialization", derive(Serialize, Deserialize))] | |||
| pub struct GLLimits { | |||
| pub max_vertex_attribs: u32, | |||
| pub max_tex_size: i32, | |||
| pub max_cube_map_size: i32 | |||
This comment has been minimized.
This comment has been minimized.
|
Yes, this looks great, thanks! :-) Could you please bump the Cargo.toml version and address the other comment? |
|
Good point. No problem! |
src/gl_limits.rs
Outdated
| @@ -4,12 +4,16 @@ use gleam::gl; | |||
| #[cfg_attr(feature="serde_serialization", derive(Serialize, Deserialize))] | |||
| pub struct GLLimits { | |||
| pub max_vertex_attribs: u32, | |||
| pub max_tex_size: i32, | |||
This comment has been minimized.
This comment has been minimized.
emilio
May 12, 2016
Member
Arrgh, missed this previously, sorry! This should be unsigned (texture sizes are guaranteed to be positive).
This comment has been minimized.
This comment has been minimized.
dlrobertson
May 12, 2016
Author
Contributor
Ah, true. I originally had this as unsigned, but changed it because level, width, and height are signed, but at the time of comparison they are guaranteed to be positive as well. I'll make the update.
Add max_tex_size and max_cube_map_size to GLLimits
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dlrobertson commentedMay 12, 2016
•
edited
As discussed on IRC. Add
max_tex_sizeandmax_cube_map_sizeto GLLimits. I'll then switch ontargetto select the appropriate max.Let me know if this is not what you had in mind.
This change is