Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upClamp the drawbuffer size to a minnimum, add more tests, and cleanups. #62
+123
−13
Conversation
Figured I'd rather have them.
When a framebuffer size is zero the reported status by OpenGL is (correctly) not FRAMEBUFFER_COMPLETE. We can't avoid creating a draw buffer for this, since we need to be able to execute actual GL calls. We could return an error, but I don't think that's what other implementations do. Instead, clamp the draw buffer size to a minimum of 16 pixels.
|
Makes sense! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedAug 27, 2016
The tests in the first round were unsuccessful attempts to reproduce servo/servo#12320.
The second commit fixes that.
r? @jdm