Skip to content

/ surfman

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clamp the drawbuffer size to a minnimum, add more tests, and cleanups. #62

Merged
merged 2 commits into from Aug 27, 2016
Merged

Clamp the drawbuffer size to a minnimum, add more tests, and cleanups. #62

merged 2 commits into from Aug 27, 2016
+123 −13

Commits on Aug 27, 2016

  1. Add tests that unsuccessfully try to reproduce the shadertoy issue. 

    Figured I'd rather have them.
    @emilio
    emilio committed Aug 27, 2016
    Loading status checks…
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    ea919cc

  2. Clamp draw buffer size to a minimum, in order to avoid crashes. 

    When a framebuffer size is zero the reported status by OpenGL is (correctly) not
FRAMEBUFFER_COMPLETE.

We can't avoid creating a draw buffer for this, since we need to be able to
execute actual GL calls. We could return an error, but I don't think that's what
other implementations do.

Instead, clamp the draw buffer size to a minimum of 16 pixels.
    @emilio
    emilio committed Aug 27, 2016
    Loading status checks…
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    90e8d1e
You can’t perform that action at this time.