Skip to content

/ surfman

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset the texture/rb bindings after we use them. #63

Merged
merged 3 commits into from Sep 19, 2016
Merged

Unset the texture/rb bindings after we use them. #63

merged 3 commits into from Sep 19, 2016
+4 −8

Conversation

@anholt
Copy link
Contributor

anholt commented Sep 19, 2016

Fixes webgl conformance's default-texture.html.
anholt added 3 commits Sep 18, 2016
@anholt
Unset the texture/rb bindings after we use them.
d182608 
webgl's default-texture.html was expecting to have no texture bound on
a freshly created context, but with this module in place a texture was
there.  That texture happened to be the draw buffer, creating a
feedback loop (undefined behavior).
@anholt
Drop unused khronos_api crate.
91ee7ae 
Its last use was removed in d3355c5
(gl_generator version bump) and it was causing compiler warnings in
servo.
@anholt
Bump version to 0.4.2.
Loading status checks…
e2f28d3
@emilio
Copy link
Member

emilio commented Sep 19, 2016

LGTM, thanks!
@emilio emilio merged commit 0d4be89 into servo:master Sep 19, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@emilio
Copy link
Member

emilio commented Sep 19, 2016

Published right now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@anholt @emilio
You can’t perform that action at this time.