Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement multithreading tests #68
Merged
Conversation
src/tests.rs
Outdated
|
|
||
| // Avoid drop until test ends | ||
| loop { | ||
| thread::sleep(time::Duration::from_millis(200)); |
This comment has been minimized.
This comment has been minimized.
emilio
Sep 26, 2016
Member
This is nasty ;-)
Please add another kind of mechanism to block, another pair of channels would work.
This comment has been minimized.
This comment has been minimized.
|
Neat, looks good to me with that test change. |
|
r=me |
MortimerGoro
added a commit
to MortimerGoro/rust-offscreen-rendering-context
that referenced
this pull request
Sep 27, 2016
* Implement multithreading tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
MortimerGoro commentedSep 26, 2016
I have added some multithreading tests. It happened to me that context sharing was working ok in the current test (same thread) but was failing on servo due to multithreading environment. Better to test all the scenarios ;)