Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to gl library if necessary #85

Merged
merged 1 commit into from Mar 1, 2017
Merged

Conversation

@sotaroikeda
Copy link
Contributor

sotaroikeda commented Feb 28, 2017

This fixes issue #84

Added link to gl library on linux and windows.

@sotaroikeda
Copy link
Contributor Author

sotaroikeda commented Feb 28, 2017

Add links to a library that is used by StaticGenerator

@emilio
Copy link
Member

emilio commented Feb 28, 2017

Why doesn't this link to the GL framework in OSX or EGL in android?

@sotaroikeda
Copy link
Contributor Author

sotaroikeda commented Mar 1, 2017

I did not add it because StaticGenerator is not used on mac. But instead, cgl is used and cgl defines functions of GL framework :(

It seems better to revert linking to gleam, since gleam is used out side of offscreen_gl_context. Another crates expects the library is linked by gleam.

gleam<-cgl<-glutin
<-offscreen_gl_context
<-winit

@sotaroikeda sotaroikeda closed this Mar 1, 2017
@sotaroikeda
Copy link
Contributor Author

sotaroikeda commented Mar 1, 2017

I did not add EGL in android since the link was already requested by the following.
https://github.com/emilio/rust-offscreen-rendering-context/blob/master/build.rs#L22

@sotaroikeda sotaroikeda reopened this Mar 1, 2017
@sotaroikeda sotaroikeda force-pushed the sotaroikeda:addlink branch from 69ef890 to c1541c5 Mar 1, 2017
@sotaroikeda
Copy link
Contributor Author

sotaroikeda commented Mar 1, 2017

I chose to add link at offscreen_gl_context. I updated a patch as to add link on mac. On android case, link to EGL is already exist in build.rs.

@sotaroikeda
Copy link
Contributor Author

sotaroikeda commented Mar 1, 2017

@emilio, can you review again? Thanks.

@emilio emilio merged commit a954ca7 into servo:master Mar 1, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@emilio
Copy link
Member

emilio commented Mar 1, 2017

r=me, thanks!

@glennw
Copy link
Member

glennw commented Mar 22, 2017

@sotaroikeda @emilio I'm working on the WR update in Servo - but getting a link error on android due to it trying to link libGL - any ideas where this might be coming from? The log is http://build.servo.org/builders/android/builds/5902/steps/compile/logs/stdio from servo/servo#16073 (comment).

@sotaroikeda
Copy link
Contributor Author

sotaroikeda commented Mar 23, 2017

It seems to be addressed now by 7e00056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.