Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd link to gl library if necessary #85
Conversation
|
Add links to a library that is used by StaticGenerator |
|
Why doesn't this link to the GL framework in OSX or EGL in android? |
|
I did not add it because StaticGenerator is not used on mac. But instead, cgl is used and cgl defines functions of GL framework :( It seems better to revert linking to gleam, since gleam is used out side of offscreen_gl_context. Another crates expects the library is linked by gleam. gleam<-cgl<-glutin |
|
I did not add EGL in android since the link was already requested by the following. |
|
I chose to add link at offscreen_gl_context. I updated a patch as to add link on mac. On android case, link to EGL is already exist in build.rs. |
|
@emilio, can you review again? Thanks. |
|
r=me, thanks! |
|
@sotaroikeda @emilio I'm working on the WR update in Servo - but getting a link error on android due to it trying to link libGL - any ideas where this might be coming from? The log is http://build.servo.org/builders/android/builds/5902/steps/compile/logs/stdio from servo/servo#16073 (comment). |
|
It seems to be addressed now by 7e00056 |
sotaroikeda commentedFeb 28, 2017
This fixes issue #84
Added link to gl library on linux and windows.