Skip to content

/ unicode-bidi

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues found in initial review #10

Merged
merged 7 commits into from Jul 15, 2015
Merged

Fix issues found in initial review #10

merged 7 commits into from Jul 15, 2015
+65 −31

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Jul 15, 2015

Based on PR #7. Fixes issue #4. r? @SimonSapin
mbrubeck added 7 commits Jul 15, 2015
@mbrubeck
Fix loop behavior in visual_runs
c433b01
@mbrubeck
Comment on spec omissions
1ca45bb
@mbrubeck
Fix comment typos
9ff3086
@mbrubeck
Skip removed characters in steps W1-W7
04baadf 
Originally from @SimonSapin's PR #7.
@mbrubeck
Add a FIXME comment for issue #8
a8b7a03
@mbrubeck
Assign levels to removed characters
489846e
@mbrubeck
Logic fixes for steps X1-X8.
Loading status checks…
6b186aa 
Originally from @SimonSapin's PR #7.
This was referenced Jul 15, 2015
Closed
Closed
@SimonSapin
Copy link
Member

SimonSapin commented Jul 15, 2015

@bors-servo r+
@mbrubeck mbrubeck closed this Jul 15, 2015
@mbrubeck mbrubeck reopened this Jul 15, 2015
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Jul 15, 2015

@bors-servo r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Jul 15, 2015

📌 Commit 6b186aa has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Jul 15, 2015

⌛ Testing commit 6b186aa with merge ce7595f...
bors-servo pushed a commit that referenced this pull request Jul 15, 2015
bors-servo
Auto merge of #10 - mbrubeck:review, r=SimonSapin
Loading status checks…
ce7595f 
Fix issues found in initial review

Based on PR #7. Fixes issue #4. r? @SimonSapin
@mbrubeck mbrubeck closed this Jul 15, 2015
@mbrubeck mbrubeck reopened this Jul 15, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Jul 15, 2015

⌛ Testing commit 6b186aa with merge 6d849d7...
bors-servo pushed a commit that referenced this pull request Jul 15, 2015
bors-servo
Auto merge of #10 - mbrubeck:review, r=SimonSapin
Loading status checks…
6d849d7 
Fix issues found in initial review

Based on PR #7. Fixes issue #4. r? @SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Jul 15, 2015

☀️ Test successful - travis
@bors-servo bors-servo merged commit 6b186aa into servo:master Jul 15, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jul 15, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@mbrubeck @SimonSapin @bors-servo
You can’t perform that action at this time.