Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHandle multiple paragraphs in input text. #12
Merged
+155
−130
Conversation
|
r? @pcwalton or @SimonSapin |
|
Reviewed 1 of 1 files at r1. src/lib.rs, line 82 [r1] (raw file): Comments from the review on Reviewable.io |
|
@bors-servo r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Jul 21, 2015
Handle multiple paragraphs in input text. I thought this wasn't needed for Servo, since paragraphs in HTML are (normally) based on markup, so Servo can usually just process one paragraph at a time. However, for preformatted text, the bidi algorithm must handle multiple paragraphs in a single inline flow. The important changes here are in `process_text` and `initial_scan`. Most of the other changes are just renaming variables and functions to make sense in a multi-paragraph world. `process_text` no longer returns the max embedding level. This was intended for optimizations, but wasn't actually useful in Servo. An approach like #5 can provide a replacement for this optimization. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/unicode-bidi/12) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedJul 19, 2015
I thought this wasn't needed for Servo, since paragraphs in HTML are (normally) based on markup, so Servo can usually just process one paragraph at a time. However, for preformatted text, the bidi algorithm must handle multiple paragraphs in a single inline flow.
The important changes here are in
process_textandinitial_scan. Most of the other changes are just renaming variables and functions to make sense in a multi-paragraph world.process_textno longer returns the max embedding level. This was intended for optimizations, but wasn't actually useful in Servo. An approach like #5 can provide a replacement for this optimization.