Skip to content

/ unicode-bidi

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues found in initial review #9

Closed
wants to merge 7 commits into from
Closed

Fix issues found in initial review #9

wants to merge 7 commits into from
+65 −31

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Jul 15, 2015

Based on PR #7. Fixes #4. r? @SimonSapin
mbrubeck added 7 commits Jul 15, 2015
@mbrubeck
Fix loop behavior in visual_runs
c433b01
@mbrubeck
Comment on spec omissions
1ca45bb
@mbrubeck
Fix comment typos
9ff3086
@mbrubeck
Skip removed characters in steps W1-W7
04baadf 
Originally from @SimonSapin's PR #7.
@mbrubeck
Add a FIXME comment for issue #8
a8b7a03
@mbrubeck
Assign levels to removed characters
489846e
@mbrubeck
Logic fixes for steps X1-X8.
Loading status checks…
6b186aa 
Originally from @SimonSapin's PR #7.
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Jul 15, 2015

Submitted to the wrong branch. Re-submitted as #10.
@mbrubeck mbrubeck closed this Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@mbrubeck
You can’t perform that action at this time.