Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for position:sticky #1277
Closed
Assignees
Labels
Comments
Closed
|
I can work on this one! |
mrobinson
added a commit
to mrobinson/webrender
that referenced
this issue
Aug 14, 2017
We add a new clip scroll tree node type which is a sticky frame. The StickyFrame doesn't do any clipping, but will adjust the position of its contents to satisfy a given set of sticky constraints. The constraints consist of a margin (distance from the particular edge of the viewport) and a max_offset, which determines how far the sticky frame can move from its original (scrolled) position. The design of these constraints can be modified if they are particularly unpleasant for Gecko to implement. Fixes servo#1277.
|
Sorry for the delay. I've posted a PR for this. |
mrobinson
added a commit
to mrobinson/webrender
that referenced
this issue
Aug 15, 2017
We add a new clip scroll tree node type which is a sticky frame. The StickyFrame doesn't do any clipping, but will adjust the position of its contents to satisfy a given set of sticky constraints. The constraints consist of a margin (distance from the particular edge of the viewport) and a max_offset, which determines how far the sticky frame can move from its original (scrolled) position. The design of these constraints can be modified if they are particularly unpleasant for Gecko to implement. Fixes servo#1277.
mrobinson
added a commit
to mrobinson/webrender
that referenced
this issue
Aug 16, 2017
We add a new clip scroll tree node type which is a sticky frame. The StickyFrame doesn't do any clipping, but will adjust the position of its contents to satisfy a given set of sticky constraints. The constraints consist of a margin (distance from the particular edge of the viewport) and a max_offset, which determines how far the sticky frame can move from its original (scrolled) position. The design of these constraints can be modified if they are particularly unpleasant for Gecko to implement. Fixes servo#1277.
bors-servo
added a commit
that referenced
this issue
Aug 16, 2017
Add support for position:sticky We add a new clip scroll tree node type which is a sticky frame. The StickyFrame doesn't do any clipping, but will adjust the position of its contents to satisfy a given set of sticky constraints. The constraints consist of a margin (distance from the particular edge of the viewport) and a max_offset, which determines how far the sticky frame can move from its original (scrolled) position. The design of these constraints can be modified if they are particularly unpleasant for Gecko to implement. Fixes #1277. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1573) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Aug 16, 2017
Add support for position:sticky We add a new clip scroll tree node type which is a sticky frame. The StickyFrame doesn't do any clipping, but will adjust the position of its contents to satisfy a given set of sticky constraints. The constraints consist of a margin (distance from the particular edge of the viewport) and a max_offset, which determines how far the sticky frame can move from its original (scrolled) position. The design of these constraints can be modified if they are particularly unpleasant for Gecko to implement. Fixes #1277. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1573) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Gecko currently supports position:sticky in the compositor. In order to not regress this behaviour when switching to WR we'll need WR to support it as well.
/cc @mrobinson
See also: https://bugzilla.mozilla.org/show_bug.cgi?id=1366295