Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove use of stacking context local_bounds from make_polygon #1283
Comments
|
cc @kvark @mrobinson |
|
@glennw I suppose this will be replaced by an offset? |
|
@mrobinson Yes, that's what I was thinking. |
|
It appears that we need to calculate local bounds specifically when traversing stacking context anyway, based on the children that are not |
bors-servo
added a commit
that referenced
this issue
Jul 5, 2017
Removal of SC's local_bounds Fixes #1283 Includes #1446 The bounds are now specifically computed for the children of isolated stacking contexts that need to be baked in (thus, excluding isolated children contexts). Note: the `nested` test used `local_bounds` previously and considered incorrect, thus it is fixed now. Note: breaking change r? @mrobinson <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1448) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be good to remove
local_boundsfrom the StackingContext structure (and the associated public APIs).It doesn't really have any meaning, now that we collect the bounding rect from the clip-scroll groups that make up a stacking context.
There's one piece of code that currently reads the
local_boundsfield in themake_polygonfunction.Could we modify how that function works to not require the local bounds?