Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of stacking context local_bounds from make_polygon #1283

Closed
glennw opened this issue May 23, 2017 · 4 comments
Closed

Remove use of stacking context local_bounds from make_polygon #1283

glennw opened this issue May 23, 2017 · 4 comments
Assignees

Comments

@glennw
Copy link
Member

@glennw glennw commented May 23, 2017

It would be good to remove local_bounds from the StackingContext structure (and the associated public APIs).

It doesn't really have any meaning, now that we collect the bounding rect from the clip-scroll groups that make up a stacking context.

There's one piece of code that currently reads the local_bounds field in the make_polygon function.

Could we modify how that function works to not require the local bounds?

@glennw
Copy link
Member Author

@glennw glennw commented May 23, 2017

@mrobinson
Copy link
Member

@mrobinson mrobinson commented May 26, 2017

@glennw I suppose this will be replaced by an offset?

@glennw
Copy link
Member Author

@glennw glennw commented May 26, 2017

@mrobinson Yes, that's what I was thinking.

@kvark kvark self-assigned this Jun 29, 2017
@kvark
Copy link
Member

@kvark kvark commented Jun 29, 2017

It appears that we need to calculate local bounds specifically when traversing stacking context anyway, based on the children that are not ContextIsolation::Items.

bors-servo added a commit that referenced this issue Jul 5, 2017
Removal of SC's local_bounds

Fixes #1283
Includes #1446

The bounds are now specifically computed for the children of isolated stacking contexts that need to be baked in (thus, excluding isolated children contexts).

Note: the `nested` test used `local_bounds` previously and considered incorrect, thus it is fixed now.
Note: breaking change

r? @mrobinson

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1448)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.