Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: Fractional length border edges lose some pixels #1288

Closed
Gankra opened this issue May 23, 2017 · 4 comments
Closed

Linux: Fractional length border edges lose some pixels #1288

Gankra opened this issue May 23, 2017 · 4 comments

Comments

@Gankra
Copy link
Contributor

@Gankra Gankra commented May 23, 2017

If you run this test from gecko layout/reftests/backgrounds/background-tiling-zoom-1-ref.html in Servo or in gecko with layers.advanded.border-layers, some of the borders will have missing or extra pixels near the corners.

This shows up in try on linux, as well as when run locally on the toronto office's "hawkman" machine (Ubuntu), although the two have different artifacts. I haven't been able to reproduce this on macos.

Seems like some sort of rounding issue in the shaders, as the test case has divs with fractional widths.

png image 800 x 1000 pixels

@Gankra
Copy link
Contributor Author

@Gankra Gankra commented May 23, 2017

It's possible this is related to #1279, or at least a fix for one will fix both.

@glennw
Copy link
Member

@glennw glennw commented Jan 25, 2018

I opened this test in Linux and was unable to reproduce - I didn't see any of the errors above, they looked pixel-perfect when zooming as well.

@glennw glennw closed this Jan 25, 2018
@kvark
Copy link
Member

@kvark kvark commented Jan 31, 2018

@gankro please remind me tomorrow. I recall you were able to reproduce it. Now we just need to capture it :)

@Gankra
Copy link
Contributor Author

@Gankra Gankra commented Jan 31, 2018

Yeah I'll double check it on hawkman. I expect this has gone away since y'all have rewritten the border shaders like twice since I filed this bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.