Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWebrender doesn't curve borders if both neighbours are invisible #1291
Comments
|
I'm looking into fixing this, since it should be straightforward. |
bors-servo
added a commit
that referenced
this issue
May 25, 2017
don't take rectangular border fast path for curved borders fixes #1291 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1293) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here are two borders that should render the same (to the human eye) but don't in webrender:
left (incorrect render):
right (correct render):
The problem is that webrender seems to give up on applying curvature if both neighbours (in this case left and right) have no rendered size. This can be accomplished by either
border-width: 0orstyle: none-- in this case both.This is seen in this gecko reftest:
layout/reftests/border-radius/corner-joins-1.xhtml-- both servo and gecko feed webrender zero-size borders.