Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior when combining filters #1354

Closed
mrobinson opened this issue Jun 9, 2017 · 1 comment
Closed

Unexpected behavior when combining filters #1354

mrobinson opened this issue Jun 9, 2017 · 1 comment
Assignees
Labels

Comments

@mrobinson
Copy link
Member

@mrobinson mrobinson commented Jun 9, 2017

I have observed that opacity filters do not combine as I would expect. For instance the two rectangles in the following wrench output are a different color:

root:
  items:
    - type: stacking-context
      bounds: [10, 10, 500, 500]
      filters: [opacity(0.50), opacity(0.50)]
      items:
        - type: rect
          bounds: [10, 10, 100, 100]
          color: green
    - type: stacking-context
      bounds: [110, 10, 500, 500]
      filters: [opacity(0.25)]
      items:
        - type: rect
          bounds: [10, 10, 100, 100]
          color: green

screenshot

@mrobinson mrobinson added the type: bug label Jun 9, 2017
@mrobinson
Copy link
Member Author

@mrobinson mrobinson commented Jun 9, 2017

@glennw Perhaps this is an issue with premultiplied alpha?

@kvark kvark self-assigned this Jul 17, 2017
bors-servo added a commit that referenced this issue Jul 19, 2017
Pre-multiplied alpha for the blend pass

Fixes #1449, fixes #1354
Running Servo tests is pending... Done.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1493)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.