Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename webrender_traits into webrender_api #1369

Closed
nical opened this issue Jun 13, 2017 · 1 comment
Closed

Rename webrender_traits into webrender_api #1369

nical opened this issue Jun 13, 2017 · 1 comment

Comments

@nical
Copy link
Collaborator

@nical nical commented Jun 13, 2017

The crate name webrender_traits is misleading at best. It would be nice to publish webrender on crates.io but before doing this I would like webrender_traits to have a less confusing name.

Thoughts ?

cc @glennw @kvark

@Gankra
Copy link
Contributor

@Gankra Gankra commented Jun 13, 2017

I agree, this is the right name for it.

bors-servo added a commit that referenced this issue Jun 30, 2017
Rename webrender_traits into webrender_api, reexport in webrender.

This does the change I proposed in #1369, and reexports webrender_api in webrender under the webrender::api namespace. This way things that depend on both webrender and webrender_api (everything except servo at the moment), can just have a dependency to webrender and use the reexported api.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1381)
<!-- Reviewable:end -->
@nical nical closed this Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.