Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for unifying inner clip rectangle #1400

Closed
kvark opened this issue Jun 19, 2017 · 2 comments
Closed

Support for unifying inner clip rectangle #1400

kvark opened this issue Jun 19, 2017 · 2 comments

Comments

@kvark
Copy link
Member

@kvark kvark commented Jun 19, 2017

Current implementation is limited by this bit:

                // TODO(gw): local inner is only valid if there's a single clip (for now).
                // This can be improved in the future, with some proper
                // rectangle region handling.
                if sources.len() > 1 {
                    local_inner = None;
                }

Removing it causes a failure in "inset-border-radius-ref.yaml". I don't think it will be difficult to investigate and fix.
cc @glennw

@kvark
Copy link
Member Author

@kvark kvark commented Jun 19, 2017

reftestbeauty

@glennw
Copy link
Member

@glennw glennw commented Dec 1, 2017

@kvark I think this is resolved by the recent clip changes by @mrobinson. Should we close this?

@kvark kvark closed this Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.