Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve3D baking space #1447

Closed
kvark opened this issue Jul 1, 2017 · 2 comments
Closed

Preserve3D baking space #1447

kvark opened this issue Jul 1, 2017 · 2 comments

Comments

@kvark
Copy link
Member

@kvark kvark commented Jul 1, 2017

We bake each preserve-3D stacking context in screen space as of a43b0c2 in order to get proper text rendering and anti-aliasing of the contents. However, this only works when preserve-3D forms isolated branches of the SC tree. This appear to not always be the case...

Consider the following tree: a 3D context A may contain 2D context B that contains another 3D context C. Baking of C should not be made in screen space but rather in B space, since B will participate in plane-splitting with A contents/children and is rotated in general case.

The quality-focused solution would probably involve having separate baking paths for screen space versus local space, and we'll fall-back to the latter if former is not an option (like in the example above). This is unfortunately going to increase the implementation complexity.

cc @glennw

@glennw
Copy link
Member

@glennw glennw commented Dec 1, 2017

We have some support for this now - each Picture can specify a RasterizationSpace internally. However, we need to expose this properly and make sure it works with clip masks etc.

@kvark
Copy link
Member Author

@kvark kvark commented Sep 20, 2018

Fixed by #3030

@kvark kvark closed this Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.