Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow offsets don't actually offset the content #1479

Closed
Gankra opened this issue Jul 13, 2017 · 3 comments
Closed

Shadow offsets don't actually offset the content #1479

Gankra opened this issue Jul 13, 2017 · 3 comments

Comments

@Gankra
Copy link
Contributor

@Gankra Gankra commented Jul 13, 2017

It appears that it only offsets the clipped/masked region:

From reftests/text/shadow-complex.yaml (with offset on red shadow set to [10, 10]) (mesa).

screen shot 2017-07-13 at 11 12 17 am

(Note the T at the start)

From running servo on https://gankro.github.io/blah/webtests/text.html (macos sierra):

screen shot 2017-07-13 at 10 37 51 am

(Note the m on "cillum")

@Gankra
Copy link
Contributor Author

@Gankra Gankra commented Jul 13, 2017

Note: I tried messing around with the bounds/local_rect a bunch and nothing happened. I assume you intended to place the content according to it, but forgot to, since the only place you seem to factor in offset is in translating that rect.

@glennw
Copy link
Member

@glennw glennw commented Jul 13, 2017

I'll look into these today.

@kvark
Copy link
Member

@kvark kvark commented Jul 14, 2017

Fixed by #1482

@kvark kvark closed this Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.