Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upapply subpixel-aa to non-blurred text-shadows #1483
Closed
Comments
glennw
pushed a commit
to glennw/webrender
that referenced
this issue
Jul 17, 2017
* Clamp UV fetches to 0.5 texels inside the UV rect for ps_cache and cs_blur shaders. Hopefully, this will fix the text-shadow artifacts that appear on some machines / tests. * Add fast path for text that has blur radius of zero. This is a useful optimization, and also needed to pass some of the Servo reftests, which don't support fuzzy tests. Text runs with a zero shadow get pushed through the normal text run path, which now supports an offset parameter. * Respect subpixel AA mode for text runs with zero blur radius. Fixes servo#1483. * Respect disabled text AA mode for text runs with zero blur radius. This is needed by some of the Servo reftests. * Simplify the GPU cache layout of text-shadow primitives. They now match that of a normal text run primitive, but have several runs concatenated.
bors-servo
added a commit
that referenced
this issue
Jul 17, 2017
Various improvements to text-shadow support. * Clamp UV fetches to 0.5 texels inside the UV rect for ps_cache and cs_blur shaders. Hopefully, this will fix the text-shadow artifacts that appear on some machines / tests. * Add fast path for text that has blur radius of zero. This is a useful optimization, and also needed to pass some of the Servo reftests, which don't support fuzzy tests. Text runs with a zero shadow get pushed through the normal text run path, which now supports an offset parameter. * Respect subpixel AA mode for text runs with zero blur radius. Fixes #1483. * Respect disabled text AA mode for text runs with zero blur radius. This is needed by some of the Servo reftests. * Simplify the GPU cache layout of text-shadow primitives. They now match that of a normal text run primitive, but have several runs concatenated. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1488) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Gecko does this. Should hopefully be a simple fast-path.