Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHandle big size of instance property in gpu_cache. #1590
Closed
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@kvark @glennw @nical
If we have a big size of glyph(using dl::push_text()), we could hit the assert at [1].
Here is the STR:
There are two problem here.
a) gecko should not send all glyph data into WR. The glyph data should be culled before sending the push_text(). In this case, gecko send all glyph data to WR even though a lot of glyph are not seen.
b) if a page really contain so many glyph on the screen, WR should split this glyph array into several batches. Otherwise, we hit the MAX_VERTEX_TEXTURE_WIDTH limit in WR.
[1]
https://hg.mozilla.org/mozilla-central/annotate/c01aa84ded7e/gfx/webrender/src/gpu_cache.rs#l252