Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPropagate errors during rendering WebRender instead of panicking #1631
Labels
Comments
bors-servo
added a commit
that referenced
this issue
Aug 31, 2017
Propagate errors during rendering WebRender instead of panicking Fixes #1631 I am not sure this approach is OK. It makes render() as not to panic when a shader error happens. @glennw @kvark @nical <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1633) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#768 propagates errors when initializing WebRender. But it is not enough to propagate errors instead of panicking, since actual shader compilations happen when they are used under Renderer::render() in normal use cases. Then the render() panics when the compilations failed. gecko want to avoid the panic.
The problem of gecko is tracked by Bug 1390138