Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement font-variation support (needed for -apple-system fonts) #1655
Labels
Comments
|
Discussing with @lsalzman, it seems like this is probably the result of not sending font variations. Needs gecko and webrender work. |
Gankra
changed the title
bors-servo
added a commit
that referenced
this issue
Sep 20, 2017
support font variations for font instances This adds support for font variations in an effort to correct the problem identified in #1655 and https://bugzilla.mozilla.org/show_bug.cgi?id=1397458 Apple system fonts may use font variations internally to identify modifications of a base raw font for styling, namely bold. To correctly supply these fonts to WebRender, we need to not only send over the raw font, but any internal font variation information. This makes this possible to receive it on the WebRender side, in cooperation with changes on the Gecko side to supply it. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1714) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Sep 20, 2017
support font variations for font instances This adds support for font variations in an effort to correct the problem identified in #1655 and https://bugzilla.mozilla.org/show_bug.cgi?id=1397458 Apple system fonts may use font variations internally to identify modifications of a base raw font for styling, namely bold. To correctly supply these fonts to WebRender, we need to not only send over the raw font, but any internal font variation information. This makes this possible to receive it on the WebRender side, in cooperation with changes on the Gecko side to supply it. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1714) <!-- Reviewable:end -->
|
Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you navigate to a github issue that mentions a user on macos with gecko, it should be bold:
Hello @gankro this is a test
But with webrendest layers-free (which hands the text to webrender) it doesn't show up as bold. I can't find anything going wrong in gecko here (it seems to be natively bold), so my current hunch is that we're processing this font incorrectly somehow. It's possible there's extra information we need gecko to send us? I don't know enough about CGFont stuff to say.