Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImage masks and rounded clips not respected on text #1765
Comments
|
Text also doesn't appear to respect rounded clip rects. So the testcase can probably be a lot simpler. |
|
We need to draw subpixel text that has a clip mask with a different blend mode. I'm going to hold off on this until the text-related work that @lsalzman is doing lands, so we don't conflict. |
|
@lsalzman's work has landed, so this is can now be worked on, I think. |
|
#1855 fixed this for black text but causes buggy rendering with brighter text. I've created a testcase at http://tests.themasta.com/text-masking.zip that renders text with a fade-out mask with different text colors: You can see that, the brighter the text is, the more a low alpha value is counted as "draw this text as extra opaque white" instead of "draw this text at a given alpha". |
Fixes servo#1765. Fixes servo#1881.

https://bugzilla.mozilla.org/show_bug.cgi?id=1403333
The text in this testcase is drawn without any fade-out effect:
Save to
wrench/reftests/mask/text.yaml, and add this image with the namelinear-gradient.pngnext to it:Screenshot:

You can see that the blue rectangle respects the mask but the text does not.