Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constructing font atlas without factoring in StackingContexts is broken #1804

Closed
Gankra opened this issue Oct 4, 2017 · 4 comments
Closed

constructing font atlas without factoring in StackingContexts is broken #1804

Gankra opened this issue Oct 4, 2017 · 4 comments

Comments

@Gankra
Copy link
Contributor

@Gankra Gankra commented Oct 4, 2017

We need to factor in scale transforms when constructing the font atlas, or else we get a blurry mess (with subpixel aa!)

Webrender:
screen shot 2017-10-04 at 1 02 21 pm

Chrome:
screen shot 2017-10-04 at 1 02 48 pm

(ignore that chrome messed up the shadow here)

@Gankra
Copy link
Contributor Author

@Gankra Gankra commented Oct 4, 2017

In particular this means parallel glyph processing on the backend is mostly busted. A possible fix would be to have PushText consult the parent stacking context(s?)'s transforms to compute this for the backend?

@glennw
Copy link
Member

@glennw glennw commented Oct 5, 2017

This depends on #1542.

@glennw
Copy link
Member

@glennw glennw commented Dec 1, 2017

@lsalzman @gankro I think this can be closed now?

@lsalzman
Copy link
Contributor

@lsalzman lsalzman commented Dec 1, 2017

Yes, this is fixed.

@glennw glennw closed this Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.