Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTransformed text seems to stretch glyph image border pixels, creating fringes around glyphs #1808
Comments
|
I'm pretty sure this is just subpixels. We currently render text before transforms, and with no regard for their existence. |
|
I agree, this depends on #1542 and is just one of the things we should make sure works correctly once that's fixed. There will probably still be cases where we want to rasterize and then transform, and in those cases, this particular rendering error should not occur. |
|
No, it's not. I'll remove it from the see also list. |
Closed
bors-servo
added a commit
that referenced
this issue
Nov 21, 2017
support font subpixel AA with content transforms This solves issue #1808. It ensures that we render subpixel AA in device space rather than layer local space, so as to side-step the issue with subpixels getting deformed by a layer transform. The engine of this is FontTransform, which is the upper 2x2 submatrix of the layer transform and which is stored in the FontInstance - automatically and necessarily becoming part of the font key. That transform has to be passed down to the font backend so that rasterization actually uses it. In the text shader, we can just optionally derive this transform from the layer transform, without having to pass in any other state. We have to make sure we only conditionally use it, as not all glyphs will be pre-transformed. To that end, I made TextShader a replacement for PrimitiveShader (as discussed with Glenn). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2058) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://bugzilla.mozilla.org/show_bug.cgi?id=1405953
Testcase