Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple inset box shadows don't draw anything #183

Closed
glennw opened this issue Feb 11, 2016 · 1 comment
Closed

Simple inset box shadows don't draw anything #183

glennw opened this issue Feb 11, 2016 · 1 comment

Comments

@glennw
Copy link
Member

@glennw glennw commented Feb 11, 2016

<style>
  html, body {
    margin: 0;
  }
  .b {
    width: 300px;
    height: 20px;
    margin: 50px;
    background: green;
    box-shadow: inset 0 0 0 2px #0F0;
  }

</style>


  <div class="b">
  </div>
@glennw
Copy link
Member Author

@glennw glennw commented Feb 11, 2016

anderco added a commit to anderco/webrender that referenced this issue Jun 7, 2016
A positive spread value makes an inset shadow smaller, so take the clip
mode into account when computing the box shadow size.

Fixes servo#183
anderco added a commit to anderco/webrender that referenced this issue Jun 9, 2016
A positive spread value makes an inset shadow smaller, so take the clip
mode into account when computing the box shadow size.

Fixes servo#183

v2: Don't introduce extra variable.
bors-servo added a commit that referenced this issue Jun 9, 2016
Inset box shadow fixes

Hi,

I found this project interesting and figured I try to contribute, so I looked at the open issues and tried to fix #183. I saw a couple more issues with inset box shadows, so here's an attempt to fix those.

I'm not exactly sure what's the best way to test these changes. I did manual testing, but pointers for a better method are appreciated.

Thanks,
Ander
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.