Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some text has black boxes around the glyphs #1839

Closed
mstange opened this issue Oct 10, 2017 · 7 comments
Closed

Some text has black boxes around the glyphs #1839

mstange opened this issue Oct 10, 2017 · 7 comments
Labels
bugzilled type: bug

Comments

@mstange
Copy link
Contributor

@mstange mstange commented Oct 10, 2017

https://bugzilla.mozilla.org/show_bug.cgi?id=1407345

That bug has a testcase which uses mix-blend-mode, but @gankro tells me he has also seen this issue with 3d transforms.

screen shot 2017-10-10 at 2 04 28 pm
@Gankra
Copy link
Contributor

@Gankra Gankra commented Oct 10, 2017

Mine was https://bugzilla.mozilla.org/show_bug.cgi?id=1406179

data:text/html,<div style="perspective:1000px"><div style="transform-style: preserve-3d">hallo

screen shot 2017-10-10 at 2 18 41 pm
@mstange
Copy link
Contributor Author

@mstange mstange commented Oct 10, 2017

After #1816, the testcase with mix-blend-mode now gets black boxes in both lines, not just in the second line.
@glennw
Copy link
Member

@glennw glennw commented Oct 11, 2017

OK, I can see the problem - we don't determine early enough that this run is on a transparent background and disable subpixel AA. Even though in the near future, we'll support that, I'm going to do the work to be able to determine earlier when a run is on a transparent background - because this is part of the planned work in #1774 anyway, that will be useful to have for several other reasons.
This was referenced Oct 11, 2017
Closed
Closed
glennw pushed a commit to glennw/webrender that referenced this issue Oct 11, 2017
@gw3583
If a stacking context is isolated, disable subpixel AA on it.
b2a2c1a 
This is a workaround / hack for servo#1839, until we properly support
subpixel AA on transparent surfaces. It extends the set of
conditions that disable subpixel AA on a stacking context.

Fixes servo#1839.
@glennw glennw mentioned this issue Oct 11, 2017
Merged
@glennw
Copy link
Member

@glennw glennw commented Oct 11, 2017

I added an interim fix in #1844.
bors-servo added a commit that referenced this issue Oct 11, 2017
@bors-servo
Auto merge of #1844 - glennw:fix-1839, r=kvark
Loading status checks…
717d298 
If a stacking context is isolated, disable subpixel AA on it.

This is a workaround / hack for #1839, until we properly support
subpixel AA on transparent surfaces. It extends the set of
conditions that disable subpixel AA on a stacking context.

Fixes #1839.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1844)
<!-- Reviewable:end -->
@mstange
Copy link
Contributor Author

@mstange mstange commented Oct 13, 2017

This testcase still shows the issue in Firefox with an updated webrender. I'm not sure if Firefox actually forwards the CSS isolation property as an isolated WebRender stacking context.
@kvark
Copy link
Member

@kvark kvark commented Oct 17, 2017

Looks like we need a reftest for this
@kvark kvark reopened this Oct 17, 2017
@gw3583
Copy link
Collaborator

@gw3583 gw3583 commented Feb 1, 2019

The bugzilla bug for this is resolved fixed.
@gw3583 gw3583 closed this Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilled type: bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@kvark @mstange @Gankra @glennw @gw3583
You can’t perform that action at this time.