Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSome diacritics not rendering on linux #1846
Closed
Comments
|
(I'll try to make a wrench test for this in the next day, but it might be font-specific) |
|
Doesn't seem font-specific, but |
|
(I think VeraBd.ttf probably just doesn't have U+0302 or U+0303) |
|
Gonna focus on some other stuff for now; someone who runs linux primarily should probably champion this. |
glennw
pushed a commit
to glennw/webrender
that referenced
this issue
Oct 13, 2017
Diacritic glyphs have a valid width and height, but a zero advance. Previously we were discarding these but they are valid glyphs. The code also checks for a width and height of 0 below, which catches non-printable glyphs such as spaces. Fixes servo#1846.
bors-servo
added a commit
that referenced
this issue
Oct 14, 2017
Fix diacritic glyphs on Linux. Diacritic glyphs have a valid width and height, but a zero advance. Previously we were discarding these but they are valid glyphs. The code also checks for a width and height of 0 below, which catches non-printable glyphs such as spaces. Fixes #1846. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1868) <!-- Reviewable:end -->
glennw
pushed a commit
to glennw/webrender
that referenced
this issue
Oct 15, 2017
Diacritic glyphs have a valid width and height, but a zero advance. Previously we were discarding these but they are valid glyphs. The code also checks for a width and height of 0 below, which catches non-printable glyphs such as spaces. Fixes servo#1846.
bors-servo
added a commit
that referenced
this issue
Oct 15, 2017
Fix diacritic glyphs on Linux. Diacritic glyphs have a valid width and height, but a zero advance. Previously we were discarding these but they are valid glyphs. The code also checks for a width and height of 0 below, which catches non-printable glyphs such as spaces. Fixes #1846. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1868) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://gankro.github.io/blah/reftests/text/fallback-mark-stacking-1.html
https://gankro.github.io/blah/reftests/text/fallback-mark-stacking-1-notref.html
works fine on mac/windows, which suggests it's a bug in webrender's font code.
On mac with webrendest gecko, these render as:
On linux, you only see the Xs.