Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black screen since PR 184 #185

Closed
paulrouget opened this issue Feb 12, 2016 · 5 comments
Closed

Black screen since PR 184 #185

paulrouget opened this issue Feb 12, 2016 · 5 comments

Comments

@paulrouget
Copy link
Collaborator

@paulrouget paulrouget commented Feb 12, 2016

Since #184, during the tab switching animation, browser.html turns black (osx).

@pcwalton
Copy link
Collaborator

@pcwalton pcwalton commented Feb 12, 2016

Huh, I'm pretty sure I tested that animation. Perhaps I messed up when preparing the patch.

I suspect this will show up as a GL error in apitrace if I can reproduce. I had some issues in the patch with trying to use textures that were deleted that I had to fix. I bet it's something like that.

@paulrouget
Copy link
Collaborator Author

@paulrouget paulrouget commented Feb 18, 2016

I see no error. But I'm not familiar with opengl and apitrace.

@glennw
Copy link
Member

@glennw glennw commented Feb 22, 2016

@paulrouget Do you want us to back that change out (it's a performance fix only) until @pcwalton is able to repro it, or is it not impacting your work much?

@paulrouget
Copy link
Collaborator Author

@paulrouget paulrouget commented Feb 22, 2016

Not blocking us. We can wait.

@bors-servo bors-servo closed this in 3208261 Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.