Inset box shadows with spread_radius > border_radius explode #1916

mstange · 2017-10-23T20:59:48Z

https://bugzilla.mozilla.org/show_bug.cgi?id=1411074

Expected vs actual results:

This seems to be caused by the sharpness_scale adjustment that's done when computing the impact of the spread radius on the corner radius. This adjustment is in the spec, but neither Firefox nor Chrome implement it, so I think we can just drop it again.

<!DOCTYPE html>
<meta charset="utf-8">

<title>Box-shadows with spread radius needs to affect non-zero border-radius</title>

<style>

body {
  margin: 0;
}

div {
  display: inline-block;
  width: 80px;
  height: 80px;
  margin: 20px;
  box-shadow: 0 0 0 10px inset blue;
}
.withRadius {
  border-radius: 20px;
}

</style>

<div style="border-radius: 20px"></div>
<div style="border-radius: 25px"></div>
<div style="border-radius: 10px"></div>
<div style="border-radius: 9px"></div>
<div style="border-radius: 8px"></div>
<div style="border-radius: 7px"></div>
<div style="border-radius: 6px"></div>
<div style="border-radius: 5px"></div>
<div style="border-radius: 4px"></div>


        Fix inset box shadows with spread radius > border radius.

Fixes servo#1916.


        Auto merge of #1918 - glennw:bs-spread, r=kvark

Fix inset box shadows with spread radius > border radius. Fixes #1916.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1918)

mstange closed this Oct 23, 2017

mstange reopened this Oct 23, 2017

mstange mentioned this issue Oct 24, 2017

Always multiply alpha with the clip's alpha. #1910

Merged

glennw pushed a commit to glennw/webrender that referenced this issue Oct 24, 2017

Fix inset box shadows with spread radius > border radius.

782ca07

Fixes servo#1916.

glennw mentioned this issue Oct 24, 2017

Fix inset box shadows with spread radius > border radius. #1918

Merged

bors-servo closed this in #1918 Oct 24, 2017

servo / webrender

Inset box shadows with spread_radius > border_radius explode #1916

Inset box shadows with spread_radius > border_radius explode #1916

mstange commented Oct 23, 2017 •

edited

servo / webrender

Join GitHub today

Inset box shadows with spread_radius > border_radius explode #1916

Inset box shadows with spread_radius > border_radius explode #1916

Comments

mstange commented Oct 23, 2017 • edited

mstange commented Oct 23, 2017 •

edited