Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove isolation conflict log in push_stacking_context #1955

Closed
GuanWen-Chen opened this issue Oct 27, 2017 · 2 comments
Closed

Remove isolation conflict log in push_stacking_context #1955

GuanWen-Chen opened this issue Oct 27, 2017 · 2 comments

Comments

@GuanWen-Chen
Copy link
Contributor

@GuanWen-Chen GuanWen-Chen commented Oct 27, 2017

There are some cases that a stacking context can contain multiple child stacking contexts with blend mode:
In the test in[1], we have two background-images applied to blend mode in the same item.

If my understanding is correct, this error log in push_stacking_context assume a stacking context can only have one child stacking context which has blend mode.

Perhaps we should remove this assumption?

[1] https://searchfox.org/mozilla-central/source/layout/reftests/css-blending/background-blending-gradient-gradient.html
[2]

@GuanWen-Chen
Copy link
Contributor Author

@GuanWen-Chen GuanWen-Chen commented Oct 27, 2017

r? @kvark

@kvark
Copy link
Member

@kvark kvark commented Nov 8, 2017

Closing according to discussion in #1956

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.