Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfast-shadows of apple emoji aren't colored #1959
Closed
Comments
|
live version is near the top of https://gankro.github.io/blah/webtests/text.html |
bors-servo
added a commit
that referenced
this issue
Dec 18, 2017
ignore glyph color data when doing fast shadows This addresses issues #1959 and #1917. We need to swizzle away the glyph's color data for emoji fast shadows. Rather than introducing more shaders/ifdefs to deal with this, I added a reasonably cheap programmable swizzle in the shader to control this. A side benefit of this is that we also get rid of the need for the separate shader with the subpixel-with-bg-color blending passes as they now just use the swizzle mechanism. In the process of this I noticed that the idea of directly stuffing the shadow color into the font on the cloned text run primitive for the fast shadow has a downside: it will usually cause the font to hash differently and so make duplicate entries in the glyph cache. So I added a shadow_color field back onto TextRunPrimitiveCpu, serving dual purposes that 1) lets the font itself hash the same while also 2) indicating down to the batching code that we have to use shadows in the first place (and thus need to enable the swizzle). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2223) <!-- Reviewable:end -->
|
Fixed in #2223. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now that we correctly prevent emoji from being effected by colors, the colors we try to apply to them as fast shadows get ignored.
test case:
screen shot (with blurred version for reference)