Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upVisible seams on transformed borders #2112
Closed
Labels
Comments
glennw
pushed a commit
to glennw/webrender
that referenced
this issue
Jan 24, 2018
Set the correct edge AA flags for border corner and edge segments. Also add support for zoom parameter on reftests and when running wrench. Add a reftest with zoomed, transformend border. Fixes servo#2112.
bors-servo
added a commit
that referenced
this issue
Jan 24, 2018
Fix AA edges on border segments. Set the correct edge AA flags for border corner and edge segments. Also add support for zoom parameter on reftests and when running wrench. Add a reftest with zoomed, transformend border. Fixes #2112. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2335) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
You can see them if you zoom into ![example](https://raw.githubusercontent.com/glennw/webrender/86348b29b49b316fb816c49a7b816544a1099609/wrench/reftests/transforms/prim-suite.png]
#2016 fixed the split code to not have T-junctions, also forced AA to be applied to the correct rectangle. #2102 improves those edges, but apparently this is not enough?
We should fix the geometry extrusion to take the edge mask into account. But that still doesn't explain why the seams are currently visible.
cc @glennw