Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inset box-shadows render incorrectly in some cases #2182

Closed
mstange opened this issue Dec 6, 2017 · 1 comment
Closed

Inset box-shadows render incorrectly in some cases #2182

mstange opened this issue Dec 6, 2017 · 1 comment
Labels
bugzilled type: bug

Comments

@mstange
Copy link
Contributor

@mstange mstange commented Dec 6, 2017

https://bugzilla.mozilla.org/show_bug.cgi?id=1423696

Testcase

Actual vs expected results:
screen shot 2017-12-06 at 2 34 15 pm

It looks like the element's shape also clips the pre-blur shadow shape, instead of just clipping the blurred result.

---
root:
  items:
    - type: stacking-context
      bounds: [0, 0, 1000, 1000]
      items:
        - type: box-shadow
          bounds: [ 22, 22, 200, 80 ]
          color: blue
          clip-mode: inset
          offset: -2 -2
          blur-radius: 20
          spread-radius: 0
          border-radius:
            top-left: [0, 0]
            top-right: [0, 0]
            bottom-left: [0, 0]
            bottom-right: [0, 0]
@demo99 demo99 mentioned this issue Jan 5, 2018
Merged
bors-servo added a commit that referenced this issue Jan 8, 2018
@bors-servo
Auto merge of #2261 - demo99:box_shadow_inset3, r=glennw
Loading status checks…
fad8ced 
Fix inflate size for inset box shadow.

The inflate size should be multiplied by 2 when downscaling to guarantee the 1 pixel extra edge.  This should fix issue #2182 and [bug 1423696](https://bugzilla.mozilla.org/show_bug.cgi?id=1423696).

gecko try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aac72b3488afd74fce9afcd4edf7ce17763bd57e&selectedJob=154326187

There is an unexpected-pass test. I will add a patch to bug 1423696.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2261)
<!-- Reviewable:end -->
@glennw
Copy link
Member

@glennw glennw commented Jan 24, 2018

This is resolved fixed in bugzilla.
@glennw glennw closed this Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilled type: bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@kvark @mstange @glennw
You can’t perform that action at this time.