Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoomed in blurred text shadows generate garbage bounding box fragments #2252

Closed
Gankra opened this issue Jan 3, 2018 · 11 comments
Closed

zoomed in blurred text shadows generate garbage bounding box fragments #2252

Gankra opened this issue Jan 3, 2018 · 11 comments
Assignees

Comments

@Gankra
Copy link
Contributor

@Gankra Gankra commented Jan 3, 2018

Try zooming in and out on this page:

data:text/html,<meta charset="utf-8"><span style="text-shadow: 2px 2px 1px red"><div>Blur<span style="color: blue">%F0%9F%8E%89</span><span style="color: rgba(0,0,0,0.7)">%F0%9F%8E%89</span><span style="color: rgba(0,0,255,0.4)">%F0%9F%8E%89</span><span style="color: transparent">%F0%9F%8E%89</span><span style="text-shadow: 2px 2px 2px red"></span></div><div>Blur<span style="color: blue">A</span><span style="color: rgba(0,0,0,0.7)">A</span><span style="color: rgba(0,0,255,0.4)">A</span><span style="color: transparent">A</span></div></span>

screen shot 2018-01-03 at 4 10 48 pm

@Gankra
Copy link
Contributor Author

@Gankra Gankra commented Jan 3, 2018

Can't repro on windows.

@Gankra
Copy link
Contributor Author

@Gankra Gankra commented Jan 3, 2018

Note the example is extra complicated just to make it easier to see, and to rule out some things. This also demonstrates the issue:

<span style="color: transparent; text-shadow: 0px 0px 1px black">A</span>
@Gankra
Copy link
Contributor Author

@Gankra Gankra commented Jan 3, 2018

In theory this makes reftests/text/shadow-single.yaml sufficient to demonstrate the issue but it seems like zoom is somehow relevant, and wrench can't do it.

@Gankra Gankra changed the title macos: blurred text shadows generate garbage bounding box fragments macos: zoomed in blurred text shadows generate garbage bounding box fragments Jan 3, 2018
@Gankra
Copy link
Contributor Author

@Gankra Gankra commented Jan 3, 2018

Actually hmm I can see this on some unzoomed characters sometimes?

@Gankra
Copy link
Contributor Author

@Gankra Gankra commented Jan 3, 2018

Or not? Seems like reset-zoom was just acting janky?

@Gankra
Copy link
Contributor Author

@Gankra Gankra commented Jan 9, 2018

Ok I spent some more time on this, and I've reproduced it on linux, macos, and windows. I wasn't seeing it initially on windows or wrench because it appears to be based on global effects on the glyph cache: you need to launch a few tabs to social media sites first and then load the example and it will work. I was able to reproduce this in a binary recording in wrench as well, although if you export any one frame as a yaml it won't reproduce the issue!

@Gankra Gankra changed the title macos: zoomed in blurred text shadows generate garbage bounding box fragments zoomed in blurred text shadows generate garbage bounding box fragments Jan 9, 2018
@Gankra
Copy link
Contributor Author

@Gankra Gankra commented Jan 9, 2018

I have shown @kvark how to reproduce this locally, hopefully they can figure this out >.>

@glennw
Copy link
Member

@glennw glennw commented Jan 9, 2018

@kvark Possibly a good use case for your new capturing WIP ? :)

@kvark
Copy link
Member

@kvark kvark commented Jan 10, 2018

@glennw ^_^ exactly what I was telling @gankro :)
This needs built-frame level of capturing, which is still to implement. I'll try to make this happen after the pending PRs are done.

@glennw
Copy link
Member

@glennw glennw commented Jan 24, 2018

I was unable to reproduce this on Linux - either via Gecko or replaying the recording in wrench. Might only appear on mac?

@kvark kvark self-assigned this Jan 24, 2018
bors-servo added a commit that referenced this issue Jan 24, 2018
Text UV clamping

Fixes #2252

Delivered to you with help of the new [capture infrastructure](http://kvark.github.io/webrender/debug/ron/2018/01/23/wr-capture-infra.html).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2338)
<!-- Reviewable:end -->
@Gankra
Copy link
Contributor Author

@Gankra Gankra commented Jan 29, 2018

Confirmed that I can't reproduce this on firefox nightly anymore (macos).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.