Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Image rendering and transform artifacts #2273

Closed
staktrace opened this issue Jan 9, 2018 · 3 comments
Closed

regression: Image rendering and transform artifacts #2273

staktrace opened this issue Jan 9, 2018 · 3 comments

Comments

@staktrace
Copy link
Contributor

@staktrace staktrace commented Jan 9, 2018

Filing for https://bugzilla.mozilla.org/show_bug.cgi?id=1421526 - there are two regressions noted in the bug, this issue is specifically about the second one which "destroyed the images of GET EARLY ACCESS." I never did actually confirm the regression range for it but I'll try to do that today.

@staktrace
Copy link
Contributor Author

@staktrace staktrace commented Jan 9, 2018

I've managed to narrow down the range to this:

*   02d9b6d9 Auto merge of #2078 - kvark:rtree, r=glennw
|\
| * 08a32a9e RenderTaskTree refactor
* |   0cc47eb8 Auto merge of #2072 - nical:dbg-flags, r=glennw
|\ \
| * | b32c990d Make servo-tidy happy.
| * | 72161329 Add toggle_debug_flags.
| * | 1365e063 Properly handle debug flags when creating the renderer.
| * | 0d934778 Use DebugFlags for time and sample queries.
|  /
* |   e83612df Auto merge of #2069 - glennw:xf, r=kvark
|\ \
| * | 0aebe2b7 Address review comments
| * | 8253bbb3 Remove manual interpolation of local space in transform shaders.
|  /
* | 00e70b3c Auto merge of #2077 - kvark:pass-kind, r=glennw
|/
* 40349b38 Strong typing for the main framebuffer pass

To narrow it down any further would require a lot of work and new custom builds so I probably won't do that unless we really need it.

@glennw
Copy link
Member

@glennw glennw commented Jan 9, 2018

@staktrace No worries, thanks! It's almost certain to be 8253bbb, so I think this is close enough.

@gw3583
Copy link
Collaborator

@gw3583 gw3583 commented Feb 4, 2019

Related bugzilla bug is closed.

@gw3583 gw3583 closed this Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.