Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrench deadlocks when a transaction contains scrolling operations. #2303

Closed
nical opened this issue Jan 15, 2018 · 2 comments
Closed

Wrench deadlocks when a transaction contains scrolling operations. #2303

nical opened this issue Jan 15, 2018 · 2 comments
Labels

Comments

@nical
Copy link
Collaborator

@nical nical commented Jan 15, 2018

For some reason wrench does not wake the event loop up if there is a scrolling operation in a transaction.
see

if !scrolled {

That's kinda confusing and error prone. This was probably done to avoid taking the snapshot in the middle of the updates when several things scroll, but we can better support this type of situation by grouping all scrolling updates inside the same transaction.

If we need anything more complicated, then wrench should do what gecko does: explicitly wait for specific epochs to be rendered before taking the snapshot.

@glennw
Copy link
Member

@glennw glennw commented Apr 6, 2018

@nical Is this resolved now? (via #2410)

@nical
Copy link
Collaborator Author

@nical nical commented Apr 6, 2018

Yep!

@nical nical closed this Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.