Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge ResourceUpdate and Transaction. #2322

Closed
nical opened this issue Jan 18, 2018 · 2 comments
Closed

Merge ResourceUpdate and Transaction. #2322

nical opened this issue Jan 18, 2018 · 2 comments
Labels
difficulty: easy type: question

Comments

@nical
Copy link
Collaborator

@nical nical commented Jan 18, 2018

ResourceUpdate was a first step in the direction of bundling several operations in a single API message, and Transaction offers that as well with in a more powerful way. We can just move ResourceUpdates methods directly in Transaction to simplify the API a bit.
@kvark
Copy link
Member

@kvark kvark commented Feb 23, 2018

Another option would be to merge it with UpdateGpuCache :)
@hgallagher1993
Copy link
Contributor

@hgallagher1993 hgallagher1993 commented Apr 17, 2018

Ya I'll pick this up ☺️
@hgallagher1993 hgallagher1993 mentioned this issue May 2, 2018
Merged
bors-servo added a commit that referenced this issue May 24, 2018
@bors-servo
Auto merge of #2718 - hgallagher1993:local_branch, r=gw3583
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5084aae 
Merge ResourceUpdate and Transaction

Fixes #2322

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2718)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy type: question
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@kvark @nical @hgallagher1993
You can’t perform that action at this time.